-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test_revset.rs: disable clippy false-positive warning #1686
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it has to be guarded by a check of the Rust version
I opened a bug for the clippy error: frondeus/test-case#122
I couldn't find an easy way to do that, surprisingly. Apparently, there's a special crate to make it possible. So, I used a slightly less elegant solution. |
https://github.com/ericseppanen/cargo-cranky seems like a useful tool for cases like mitsuhiko/insta#389 and martinvonz#1686. It should probably not be checked in, though. It can be put into `.git/info/excludes`, but that's harder on non-colocated repos and I'm not 100% certain jj properly ignores the files in there in all circumstances.
https://github.com/ericseppanen/cargo-cranky seems like a useful tool for cases like mitsuhiko/insta#389 (cc martinvonz#1834) and martinvonz#1686. It should probably not be checked in, though. It can be put into `.git/info/excludes`, but that's harder on non-colocated repos and I'm not 100% certain jj properly ignores the files in there in all circumstances. The idea is to use this with VS Code or to simplify command-line clippy invocation.
Good news: AFAICT, frondeus/test-case#122 is fixed now in every Rust version (possibly requiring a |
https://github.com/ericseppanen/cargo-cranky seems like a useful tool for cases like mitsuhiko/insta#389 (cc martinvonz#1834) and martinvonz#1686. It should probably not be checked in, though. It can be put into `.git/info/excludes`, but that's harder on non-colocated repos and I'm not 100% certain jj properly ignores the files in there in all circumstances. The idea is to use this with VS Code or to simplify command-line clippy invocation. For example, until mitsuhiko/insta#389 is fixed, you can put the following into your `Cranky.toml`: ```toml allow = [ "clippy::needless_raw_string_hashes" ] ``` Then, you can have VS code use `cargo cranky` instead of `cargo check` or `cargo clippy` and continue to use nightly clippy. The other possible solution, of course, would be to switch to beta clippy.
https://github.com/ericseppanen/cargo-cranky seems like a useful tool for cases like mitsuhiko/insta#389 (cc martinvonz#1834) and martinvonz#1686. It should probably not be checked in, though. It can be put into `.git/info/excludes`, but that's harder on non-colocated repos and I'm not 100% certain jj properly ignores the files in there in all circumstances. The idea is to use this with VS Code or to simplify command-line clippy invocation. For example, until mitsuhiko/insta#389 is fixed, you can put the following into your `Cranky.toml`: ```toml allow = [ "clippy::needless_raw_string_hashes" ] ``` Then, you can have VS code use `cargo cranky` instead of `cargo check` or `cargo clippy` and continue to use nightly clippy. The other possible solution, of course, would be to switch to beta clippy.
I opened a bug for the clippy error:
frondeus/test-case#122